Replaced Buffer constructor with Buffer.from and Buffer.alloc#51
Open
NinjaManatee wants to merge 1 commit intomhr3:masterfrom
Open
Replaced Buffer constructor with Buffer.from and Buffer.alloc#51NinjaManatee wants to merge 1 commit intomhr3:masterfrom
NinjaManatee wants to merge 1 commit intomhr3:masterfrom
Conversation
Author
|
Hi @mhr3, I'm trying to us unzip-stream in an Electron 31.2.1 project, but it doesn't work anymore (worked with Electron 29.4.4). Would it be possible for you merge this PR and publish a new release to fix the issue with Buffers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
Bufferconstructor withBuffer.from()andBuffer.alloc()where appropriate.unzip-stream no longer works with the latest Electron (31.2.1), so this needs to be updated.
Related to issue #38