Add empty_db for pg_dump directory checks#65
Merged
Conversation
Jetman80
approved these changes
Mar 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for empty_db to the PostgreSQL pg_dump directory backup verification path so that known-empty databases don’t fail size/content checks during --check runs.
Changes:
- Skip
toc.datminimum size validation when the database is listed incheck.empty_db(orALL). - Skip
TABLE DATAentry count validation when the database is listed incheck.empty_db(orALL).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the backup verification logic to better handle "empty" databases by skipping certain checks for them. Specifically, it adds logic to bypass the toc.dat file size and TABLE DATA entries checks for databases marked as empty, reducing unnecessary error logs for expected-empty databases.
Improvements to backup verification for empty databases:
empty_dbconfiguration, logging a notice instead of an error when this is the case.empty_dbconfiguration, logging a notice instead of an error when this is the case.