extmod/modbluetooth: Add support for changing the GAP device name.#6019
Merged
dpgeorge merged 1 commit intomicropython:masterfrom May 11, 2020
Merged
Conversation
|
That's a great job!~ |
Member
|
Thanks!! |
This commit allows the user to set/get the GAP device name used by service
0x1800, characteristic 0x2a00. The usage is:
BLE.config(gap_name="myname")
print(BLE.config("gap_name"))
As part of this change the compile-time setting
MICROPY_PY_BLUETOOTH_DEFAULT_NAME is renamed to
MICROPY_PY_BLUETOOTH_DEFAULT_GAP_NAME to emphasise its link to GAP and this
new "gap_name" config value. And the default value of this for the NimBLE
bindings is changed from "PYBD" to "MPY NIMBLE" to be more generic.
390b033 to
3b6c911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GAP device name of a BLE device is currently hard-coded. This PR allows the user to dynamically set/get the GAP device name used by service 0x1800, characteristic 0x2a00. The usage is:
This name appears, for example, when a phone reads characteristic 0x2a00 of a peripheral that it scans/connects to.
The name can be any string of bytes (including an interior null byte on the BTstack implementation), although the BLE spec specifies it should be UTF-8.
Docs and test are included here.