Validate user identity and roles before hub name.#314
Open
EvanSchallerer wants to merge 1 commit intomicrosoft:mainfrom
Open
Validate user identity and roles before hub name.#314EvanSchallerer wants to merge 1 commit intomicrosoft:mainfrom
EvanSchallerer wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="Cosmos Data Technologies, Inc." |
scale-tone
reviewed
Apr 14, 2026
| // Starting with nonce (used when running as a VsCode extension) | ||
| if (IsNonceSetAndValid(headers)) | ||
| { | ||
| await ThrowIfTaskHubNameIsInvalid(taskHubName); |
Contributor
There was a problem hiding this comment.
To simplify the logic (so that you don't have to call ThrowIfTaskHubNameIsInvalid() in four different places) consider just excluding task hub name validation from this method and instead validate it as the next step, after ValidateIdentityAsync() is being called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates the user's identity before validating the hub name.
Closes #313