Skip to content

Fix missing filter evaluation #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linglingye001 merged 1 commit into from
Apr 8, 2026
Merged

Fix missing filter evaluation #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/feature-management/src/featureManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,12 @@ export class FeatureManager implements IFeatureManager {
const contextWithFeatureName = { featureName: featureFlag.id, parameters: clientFilter.parameters };
if (matchedFeatureFilter === undefined) {
console.warn(`Feature filter ${clientFilter.name} is not found.`);
return false;
if (requirementType === "All") {
// A missing filter means we cannot satisfy all conditions.
return false;
}
// For "Any", skip the missing filter and continue evaluating.
continue;
}
if (await matchedFeatureFilter.evaluate(contextWithFeatureName, appContext) === shortCircuitEvaluationResult) {
return shortCircuitEvaluationResult;
Expand Down
81 changes: 81 additions & 0 deletions src/feature-management/test/featureManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,4 +248,85 @@ describe("feature manager", () => {
});

it("should override default filters with custom filters");

it("should skip missing filter and continue evaluating when requirement type is Any", () => {
const jsonObject = {
"feature_management": {
"feature_flags": [
{
"id": "MissingFilterAny",
"enabled": true,
"conditions": {
"requirement_type": "Any",
"client_filters": [
{
"name": "UnregisteredFilter",
"parameters": {}
},
{
"name": "Microsoft.Targeting",
"parameters": {
"Audience": {
"Users": [ "Alice" ]
}
}
}
]
}
},
{
"id": "MissingFilterAll",
"enabled": true,
"conditions": {
"requirement_type": "All",
"client_filters": [
{
"name": "UnregisteredFilter",
"parameters": {}
},
{
"name": "Microsoft.Targeting",
"parameters": {
"Audience": {
"Users": [ "Alice" ]
}
}
}
]
}
},
{
"id": "AllMissingFiltersAny",
"enabled": true,
"conditions": {
"requirement_type": "Any",
"client_filters": [
{
"name": "UnregisteredFilter1",
"parameters": {}
},
{
"name": "UnregisteredFilter2",
"parameters": {}
}
]
}
}
]
}
};

const provider = new ConfigurationObjectFeatureFlagProvider(jsonObject);
const featureManager = new FeatureManager(provider);
return Promise.all([
// Any: missing filter is skipped, targeting filter matches Alice => enabled
expect(featureManager.isEnabled("MissingFilterAny", {userId: "Alice"})).eventually.eq(true),
// Any: missing filter is skipped, targeting filter does not match Bob => disabled
expect(featureManager.isEnabled("MissingFilterAny", {userId: "Bob"})).eventually.eq(false),
// All: missing filter means cannot satisfy all conditions => disabled
expect(featureManager.isEnabled("MissingFilterAll", {userId: "Alice"})).eventually.eq(false),
// Any: all filters are missing => disabled (no filter can match)
expect(featureManager.isEnabled("AllMissingFiltersAny", {userId: "Alice"})).eventually.eq(false)
]);
});
});
Loading