Skip to content

Fix for wrong letter case of CONCAT algorithm name#6

Closed
bryandel wants to merge 3 commits intomicrosoft:masterfrom
bryandel:master
Closed

Fix for wrong letter case of CONCAT algorithm name#6
bryandel wants to merge 3 commits intomicrosoft:masterfrom
bryandel:master

Conversation

@bryandel
Copy link
Copy Markdown

@bryandel bryandel commented Mar 16, 2021 •
edited
Loading

For some reason, the CONCAT algorithm is in lower case

MSR-JavaScript-Crypto/lib/msrcrypto.js

Lines 7336 to 7337 in 57e04ff

operations.register("deriveKey", "concat", msrcryptoKdf.deriveKey);
operations.register("deriveBits", "concat", msrcryptoKdf.deriveBits);

While the other algorithms are in upper cases.

MSR-JavaScript-Crypto/lib/msrcrypto.js

Lines 4830 to 4834 in c2494a3

operations.register("importKey", "HMAC", msrcryptoHmac.importKey);
operations.register("exportKey", "HMAC", msrcryptoHmac.exportKey);
operations.register("generateKey", "HMAC", msrcryptoHmac.generateKey);
operations.register("sign", "HMAC", msrcryptoHmac.signHmac);
operations.register("verify", "HMAC", msrcryptoHmac.verifyHmac);

This is causing unsupported algorithm

@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@ljoy913
Copy link
Copy Markdown
Contributor

ljoy913 commented May 19, 2021

Thanks, I noticed that the CONCAT alg was also missing an ImportKey function. I intend on implementing this, with tests, and including the capitalization fix with it.

@ljoy913
Copy link
Copy Markdown
Contributor

ljoy913 commented Nov 2, 2021

fixed in 1.6.4 -- thanks

@ljoy913 ljoy913 closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryandel @ljoy913