Skip to content

Perfetto plugin - Fix for missing absolute trace start time #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KyleStorck merged 1 commit into from
Aug 19, 2021
Merged

Perfetto plugin - Fix for missing absolute trace start time #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions PerfettoCds/Pipeline/CompositeDataCookers/PerfettoFtraceEventCooker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ join arg in argsData on raw.ArgSetId equals arg.ArgSetId into args
argKeys.Add(arg.ArgKey);
switch (arg.ValueType)
{
case "json":
case "string":
values.Add(arg.StringValue);
break;
Expand Down
1 change: 1 addition & 0 deletions PerfettoCds/Pipeline/CompositeDataCookers/PerfettoGenericEventCooker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ join process in processData on thread.Upid equals process.Upid
argKeys.Add(arg.ArgKey);
switch (arg.ValueType)
{
case "json":
case "string":
values.Add(arg.StringValue);

Expand Down
7 changes: 6 additions & 1 deletion PerfettoCds/Pipeline/PerfettoSourceParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,13 @@ void EventCallback(PerfettoSqlEvent ev)
// If we have all the timing data we need, create the DataSourceInfo
if (++cnt == minQueriesForTimings)
{
if (firstEventTime != Timestamp.MaxValue && lastEventTime != Timestamp.MinValue && traceStartDateTime.HasValue)
if (firstEventTime != Timestamp.MaxValue && lastEventTime != Timestamp.MinValue)
{
if (!traceStartDateTime.HasValue)
{
logger.Warn($"Absolute trace start time can't be determined. Setting trace start time to now");
traceStartDateTime = DateTime.Now;
}
// Get the delta between the first event time and the first snapshot time
var startDelta = firstEventTime - firstSnapTime;

Expand Down