Skip to content

CPU Sampling Support#54

Merged
ivberg merged 5 commits intodevelopfrom
user/ivberg/CpuSamplingSupport
Oct 12, 2021
Merged

CPU Sampling Support#54
ivberg merged 5 commits intodevelopfrom
user/ivberg/CpuSamplingSupport

Conversation

@ivberg
Copy link
Copy Markdown
Contributor

@ivberg ivberg commented Oct 12, 2021

Add cpu sampling support per linked issue #38.

This processes Android 12 perf_sample events and walks the callstack using associated tables. The full callstack is provided and allows default advanced grouping by process, thread, callstack in a hierarchical view to quick/easily see the top callstacks in a UI.

Also
-Upgrade all the latest NuGet pkgs including Performance SDK 0.109.24 and fix breaking changes
-Fix some bugs with types not matching published schema when parsing previous Perfetto tables

ivberg added 4 commits October 8, 2021 17:03
…ta with sample & proc/thread. Missing is callstack even though the back-end is present for it.
…aking changes). Add trace processor shell logging to Perfetto UT
Copy link
Copy Markdown
Collaborator

@KyleStorck KyleStorck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a pic of the new table?

@ivberg
Copy link
Copy Markdown
Contributor Author

ivberg commented Oct 12, 2021

Can you post a pic of the new table?

Sure thing. Here is the table as showing up in the optional WPA UI

image


In reply to: 941630597

@ivberg ivberg requested a review from KyleStorck October 12, 2021 23:55
@ivberg ivberg merged commit eb85ff8 into develop Oct 12, 2021
@ivberg ivberg deleted the user/ivberg/CpuSamplingSupport branch October 20, 2021 23:27
@kartelan
Copy link
Copy Markdown

Thanks for adding this support. Is it normal to see these INVALID_MAP events in the Callstack column. I collected a trace in linux (using perfetto) and I see a lot of these:
image

@ivberg
Copy link
Copy Markdown
Contributor Author

ivberg commented Nov 15, 2021

From the traces I have seen @kartelan those seem to be present in my test traces as well. I don't know if these are normal to get or indicates a bug somewhere in Android in data collection, or in the Perfetto stack including trace processing API. I don't think it's a bug with our CPU Sampling support, but I could be wrong. You can also ask around in the Perfetto email lists or GitHub page. Please do let us know what you find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Perfetto - Support Processing of Android 12 CPU Callstack Sampling

3 participants