Conversation
…ta with sample & proc/thread. Missing is callstack even though the back-end is present for it.
…aking changes). Add trace processor shell logging to Perfetto UT
… Instruction Pointer (IP) Module & Function
KyleStorck
reviewed
Oct 12, 2021
Collaborator
KyleStorck
left a comment
There was a problem hiding this comment.
Can you post a pic of the new table?
PerfettoCds/Pipeline/CompositeDataCookers/PerfettoCpuSamplingEventCooker.cs
Outdated
Show resolved
Hide resolved
PerfettoCds/Pipeline/CompositeDataCookers/PerfettoCpuSamplingEventCooker.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
Sure thing. Here is the table as showing up in the optional WPA UI In reply to: 941630597 |
KyleStorck
approved these changes
Oct 12, 2021
Contributor
Author
|
From the traces I have seen @kartelan those seem to be present in my test traces as well. I don't know if these are normal to get or indicates a bug somewhere in Android in data collection, or in the Perfetto stack including trace processing API. I don't think it's a bug with our CPU Sampling support, but I could be wrong. You can also ask around in the Perfetto email lists or GitHub page. Please do let us know what you find out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Add cpu sampling support per linked issue #38.
This processes Android 12 perf_sample events and walks the callstack using associated tables. The full callstack is provided and allows default advanced grouping by process, thread, callstack in a hierarchical view to quick/easily see the top callstacks in a UI.
Also
-Upgrade all the latest NuGet pkgs including Performance SDK 0.109.24 and fix breaking changes
-Fix some bugs with types not matching published schema when parsing previous Perfetto tables