Merged
Conversation
mslukebo
commented
Nov 12, 2021
KyleStorck
approved these changes
Nov 12, 2021
ivberg
requested changes
Nov 12, 2021
Contributor
ivberg
left a comment
There was a problem hiding this comment.
As discussed, something in these changes has broken discovery of tables for LTTng from previous version in the UI. Ideally this would be caught by Unit Tests, but we are not sure if this is possible right now
Contributor
Author
Turns out I wasn't copying all the files 😄 . Everything appears to work |
ivberg
approved these changes
Nov 12, 2021
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds IsDataAvailable methods to Perfetto's cooker tables, so tables without data do not appear in WPA.