Conversation
benfeely
previously approved these changes
Aug 13, 2018
added 2 commits
August 13, 2018 20:07
# Conflicts: # libs/fabric/package.json # libs/fabric/src/lib/components/command-bar/command-bar.component.ts
benfeely
approved these changes
Aug 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #5.
Angular does detect the changes (as can be seen when inspecting the instance, as well as
<counter>element in the DOM), but theReactRendererdoes not re-render the inner React componentDefaultButton(note that thengOnChangesofFabDefaultButtonComponentis triggered though).The solution proposed in this PR is to manually add all
ReactWrapperComponents as react root nodes to theReactRenderer, which means that they will be re-rendered as needed.This is a breaking change, since
ReactWrapperComponentnow requires aRenderer2to be injected, meaning any derived components need to have it injected and pass it up. This covers most of the changes in this PR.