Add all generated files to the repo and fix dependencies#147
Merged
wravery merged 3 commits intomicrosoft:masterfrom Jan 8, 2021
Merged
Add all generated files to the repo and fix dependencies#147wravery merged 3 commits intomicrosoft:masterfrom
wravery merged 3 commits intomicrosoft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the new version awareness depends on CMake more than I would like because there are no copies of the
internal/Version.hor*.rcfiles added to the repo. This makes it difficult to wrap another build system around a standalone source archive.All of the files generated by CMake should now be included in the sources, and CMake will update them if they change. While I was at it, I untangled a bunch of generated file dependencies and used
cmake -E copy_if_differentto minimize modifications to the generated files. Targets which depend on generated files should only trigger a rebuild if that generated file actually changes.