Skip to content

Generate clients to go with cppgraphqlgen services#165

Merged
wravery merged 66 commits intomicrosoft:mainfrom
wravery:clientgen
May 28, 2021
Merged

Generate clients to go with cppgraphqlgen services#165
wravery merged 66 commits intomicrosoft:mainfrom
wravery:clientgen

Conversation

@wravery
Copy link
Copy Markdown
Contributor

@wravery wravery commented May 27, 2021 •
edited
Loading

This PR fixes #161. It adds the clientgen utility and a common GraphQLClient.h header and graphqlclient runtime library which can be used to pre-parse/pre-validate a query and parse the response into a statically typed struct instead of handling arbitrary.

The initial motivation was to make consuming a cppgraphqlgen service easier, but the performance savings for this approach turned out to really nice. On my machine, the single-threaded throughput of the client_benchmark using a clientgen version of the same query is more than twice the throughput of benchmark which dynamically parses/validates the query and serializes the results to JSON instead of the strongly typed struct:

> benchmark 10000
Iterations: 10000
Throughput: 9184.42 requests/second
Overall (microseconds): 1088799 total, 108.88 average
Parse (microseconds): 49 median, 43 minimum, 286 maximum, 49.4173 average
Validate (microseconds): 5 median, 4 minimum, 63 maximum, 5.477 average
Resolve (microseconds): 46 median, 39 minimum, 317 maximum, 50.139 average
ToJSON (microseconds): 2 median, 1 minimum, 26 maximum, 2.0137 average

> client_benchmark 10000
Iterations: 10000
Throughput: 20755.2 requests/second
Overall (microseconds): 481806 total, 48.1806 average
Resolve (microseconds): 45 median, 35 minimum, 314 maximum, 46.1472 average
ParseServiceResponse (microseconds): 0 median, 0 minimum, 31 maximum, 0.2003 average
ParseResponse (microseconds): 1 median, 1 minimum, 30 maximum, 1.5946 average

wravery and others added 30 commits May 17, 2021 22:11
@wravery
Clone SchemaGenerator.* into ClientGenerator.* and bump the version
2f3cf47
@wravery
Refactor common logic into GeneratorUtil.*
a98690b
@wravery
Validate requests against the schema
529abc4
@wravery
Cleanup leftover initializer_list reference
3af63f6
@wravery
Export functions from DLLs for clientgen
5e45c3e
@wravery
Move converter export declarations to graphql::service
fb54030
@wravery
Fix the GRAPHQLINTROSPECTION_EXPORT macro
84d1d7d
@wravery
Refactor common schema code into SchemaLoader
c8b4e37
@wravery
Minor fixes to clientgen
c73b05e
@wravery
Fix NON_NULL wrappers in clientgen runtime schema
eb5906a
@wravery
Add sample request documents to test clientgen
870edf3
@wravery
Fix update_samples dependencies
bd4c980
@wravery
Refactor GraphQLService.cpp visitors into RequestLoader.*
3eb7768
@wravery
Generate placeholder client samples with CMake
b44df99
@wravery
Fix update_version dependencies so source dirs are not outputs
589b104
@wravery
Put resolver visitors back in GraphQLService.cpp
dd9dad5
@wravery
Add an operation name argument to clientgen
d6b6e97
@wravery
Move visitors back to GraphQLService because of variables
f0dde15
@wravery
Move request parsing and validation to RequestLoader
a7c90f6
@wravery
Simplify RequestLoader initialization
8931442
@wravery
Output the original request in a header comment block
1129477
@wravery
Get the operation type and name from the request doc
4fa3e7b
@wravery
Finish RequestLoader
efce1b0
@wravery
Start replacing content from schemagen in clientgen
8bd60de
@wravery
Add namespaces to clientgen output
b8f5208
@wravery
Start building client samples
c42e09c
@wravery
Keep track of field positions in RequestLoader
98c6f1b
@wravery
Build header path from prefix instead of full path from command line
79db4d1
@wravery
Cache stable heap allocations in getSafeCppName
09ce9b8
@wravery
Store key with value allocation to index on std::string_view
e3033c4
wravery and others added 28 commits May 24, 2021 22:20
@wravery
Output the Response structs
09c967a
@wravery
Add an enum type to the Query to test clientgen
eaa0619
@wravery
Add enum serialize/parse and start on input serialize
68d0812
@wravery
Move Base64 conversions from GraphQLService to GraphQLResponse
4114b38
@wravery
Replace missing service::schema_exception with std::logic_error
44b0629
@wravery
Switch the closing namespace comments to C++ style
d5fdf0a
@wravery
Use doc comment syntax for request comment blocks
310e845
@wravery
Add ModifiedVariable and ModifiedResponse in GraphQLClient
04d8225
@wravery
Implement serializeVariables
f4c99d2
@wravery
Fix microsoft#161 implement parseResponse
f8e5431
@wravery
Fix build break
c682643
@wravery
Fix DLL build on Windows
d8c0d61
@wravery
Add template <> to specializations
60e6481
@wravery
Add tests and fix found bugs
6347a7e
@wravery
Copy graphqlclient.dll to the test directory
d432a8f
@wravery
Update README describing clientgen and graphqlclient
faaa2cd
@wravery
Test and fix union types
a38f304
@wravery
Default initialize Variables members
c092c11
@wravery
Make testTaskStatus non-nullable so test default enum init
634e01f
@wravery
Declare embedded structs first for better layout
dfecf03
@wravery
Remove extra blank line after includes
66cbe33
@wravery
Remove duplicate copyright and generated file warning comments
774c28f
@wravery
Minor edits to the README
d92d8f6
@wravery
Add a client_benchmark utility to compare with dynamic parse/serialize
78513c6
@wravery
Split PegtlTests.cpp into 3 grammar variants to speeed up build
bd7bcbf
@wravery
Add new files to install targets
a224fea
@wravery
Move more headers into graphqlservice/internal
063dd54
@wravery
Simplify splitting service response into data and errors
cef14e1
@wravery wravery merged commit 9cbad08 into microsoft:main May 28, 2021
@wravery wravery deleted the clientgen branch June 15, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: generate GraphQL clients

1 participant

@wravery