Skip to content

Read default volume from device settings at start#987

Merged
pelikhan merged 1 commit intomicrosoft:masterfrom
maciejmrozinski:read-default-volume
Sep 9, 2020
Merged

Read default volume from device settings at start#987
pelikhan merged 1 commit intomicrosoft:masterfrom
maciejmrozinski:read-default-volume

Conversation

@maciejmrozinski
Copy link
Copy Markdown
Contributor

@maciejmrozinski maciejmrozinski commented Sep 9, 2020

Changes:

  • instead of setting 50 as default volume, get real volume from brick system settings (if cannot read value, go back to default 50)
  • new method/block volume() is available to read current volume value
  • in simulator override setVolume() method (now it has some weird Math.max() logic)
  • fixes can't turn volume off #745

This change DO NOT allow to change brick volume setting.

@pelikhan
Copy link
Copy Markdown
Member

pelikhan commented Sep 9, 2020

This looks great!

@pelikhan pelikhan merged commit a157943 into microsoft:master Sep 9, 2020
pelikhan pushed a commit that referenced this pull request Sep 9, 2020
@maciejmrozinski @pelikhan
Read default volume from device settings at start (#987)
0d7c1f0
@maciejmrozinski maciejmrozinski deleted the read-default-volume branch September 9, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhan pelikhan pelikhan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

can't turn volume off

2 participants

@maciejmrozinski @pelikhan