Skip to content

[opentelemetry-cpp] Add support for otlp-file feature/component#46893

Merged
BillyONeal merged 7 commits intomicrosoft:masterfrom
stephengtuggy:stephengtuggy-opentelemetry-otlp-file
Aug 13, 2025
Merged

[opentelemetry-cpp] Add support for otlp-file feature/component#46893
BillyONeal merged 7 commits intomicrosoft:masterfrom
stephengtuggy:stephengtuggy-opentelemetry-otlp-file

Conversation

@stephengtuggy
Copy link
Copy Markdown
Contributor

@stephengtuggy stephengtuggy commented Aug 12, 2025 •
edited
Loading

Fixes #46891
Fixes #46884

If this PR updates an existing port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@stephengtuggy stephengtuggy mentioned this pull request Aug 12, 2025
Closed
@stephengtuggy stephengtuggy changed the title [opentelemetry] Add support for otlp-file feature/component [opentelemetry-cpp] Add support for otlp-file feature/component Aug 13, 2025
@stephengtuggy stephengtuggy mentioned this pull request Aug 13, 2025
Closed
@stephengtuggy
Copy link
Copy Markdown
Contributor Author

stephengtuggy commented Aug 13, 2025

Is it acceptable to mark this as failing on UWP platforms, and leave it at that? Or should I try to get it working on those platforms as well?

@stephengtuggy stephengtuggy marked this pull request as ready for review August 13, 2025 02:14
BillyONeal
BillyONeal approved these changes Aug 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it acceptable to mark this as failing on UWP platforms, and leave it at that? Or should I try to get it working on those platforms as well?

Of course we would love things to work on more platforms but a supports clause is fine. Thanks for the feature!

@BillyONeal BillyONeal added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Aug 13, 2025
@stephengtuggy
Copy link
Copy Markdown
Contributor Author

stephengtuggy commented Aug 13, 2025

Is it acceptable to mark this as failing on UWP platforms, and leave it at that? Or should I try to get it working on those platforms as well?

Of course we would love things to work on more platforms but a supports clause is fine. Thanks for the feature!

You're welcome, and thank you!

@BillyONeal BillyONeal merged commit 44a1e4e into microsoft:master Aug 13, 2025
18 checks passed
@stephengtuggy stephengtuggy deleted the stephengtuggy-opentelemetry-otlp-file branch August 13, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@vicroms vicroms vicroms approved these changes

Assignees

No one assigned

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[opentelemetry-cpp] Support OTLP_FILE functionality [opentelemetry-cpp] should specify protobuf as a dependency

3 participants

@stephengtuggy @BillyONeal @vicroms