[sbgecom] New port#46919
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Aug 14, 2025
AlexandrePTJ:sbgecom
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree [company="SBG Systems"] |
Contributor
Author
|
@microsoft-github-policy-service agree company="SBG Systems" |
BillyONeal
reviewed
Aug 14, 2025
Member
BillyONeal
left a comment
There was a problem hiding this comment.
- There is an embedded copy of cjson which would normally need to come from the 'cjson' port to avoid breaking the one definition rule, but use of that seems to be guarded for
BUILD_EXAMPLESwhich we set to off. - There's an attempt to
FetchContentfor argtable3, but that's also guarded and disabled as built here, so it should be fine.
Everything else seems to be OK; thanks for the new port!
BillyONeal
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sbgECom library to vcpkg ports
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.