Skip to content

[sbgecom] New port#46919

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
AlexandrePTJ:sbgecom
Aug 14, 2025
Merged

[sbgecom] New port#46919
BillyONeal merged 3 commits intomicrosoft:masterfrom
AlexandrePTJ:sbgecom

Conversation

@AlexandrePTJ
Copy link
Copy Markdown
Contributor

Add sbgECom library to vcpkg ports

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • [x ] Only one version is added to each modified port's versions file.

@AlexandrePTJ
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree [company="SBG Systems"]

@AlexandrePTJ
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="SBG Systems"

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is an embedded copy of cjson which would normally need to come from the 'cjson' port to avoid breaking the one definition rule, but use of that seems to be guarded for BUILD_EXAMPLES which we set to off.
  • There's an attempt to FetchContent for argtable3, but that's also guarded and disabled as built here, so it should be fine.

Everything else seems to be OK; thanks for the new port!

@BillyONeal BillyONeal merged commit dcf6516 into microsoft:master Aug 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants