Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
I don't understand why x86_windows keeps failing 😔 |
3158d07 to
bd845bb
Compare
Contributor
Author
|
Everything passed 😅 |
dg0yt
reviewed
Sep 3, 2025
Contributor
dg0yt
left a comment
There was a problem hiding this comment.
(Community feedback.)
Repology check: LGTM,
https://repology.org/project/svt-av1/information
972eb57 to
c6cb4c2
Compare
BillyONeal
reviewed
Sep 4, 2025
BillyONeal
reviewed
Sep 4, 2025
ca15eaa to
59d3402
Compare
59d3402 to
c68f5d9
Compare
Member
|
Marking with |
Member
|
@ras0219-msft points out that the private header in question only contains statics, macros, and 2 extern function declarations meaning our usual ODR concerns are less likely than normal to happen. Also we all noted that svt-av1 and aom are both "owned" by the same people. I checked that there are no conflicting generated headers or libs. |
vicroms
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.This is my first time creating a port, hope i got everything right 😅