Skip to content

[svt-av1] Add new port#47186

Merged
vicroms merged 7 commits intomicrosoft:masterfrom
sonozaki-noriko:svt-av1
Sep 12, 2025
Merged

[svt-av1] Add new port#47186
vicroms merged 7 commits intomicrosoft:masterfrom
sonozaki-noriko:svt-av1

Conversation

@sonozaki-noriko
Copy link
Copy Markdown
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

This is my first time creating a port, hope i got everything right 😅

@sonozaki-noriko
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@sonozaki-noriko
Copy link
Copy Markdown
Contributor Author

I don't understand why x86_windows keeps failing 😔

@sonozaki-noriko
Copy link
Copy Markdown
Contributor Author

Everything passed 😅

@sonozaki-noriko sonozaki-noriko marked this pull request as ready for review September 3, 2025 16:09
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Community feedback.)

Repology check: LGTM,
https://repology.org/project/svt-av1/information

Comment thread ports/svt-av1/android-llvm.diff Outdated
Comment thread ports/svt-av1/portfile.cmake Outdated
Comment thread ports/svt-av1/portfile.cmake Outdated
Comment thread ports/svt-av1/portfile.cmake Outdated
Comment thread ports/svt-av1/portfile.cmake Outdated
Comment thread ports/svt-av1/usage Outdated
@sonozaki-noriko sonozaki-noriko force-pushed the svt-av1 branch 3 times, most recently from 972eb57 to c6cb4c2 Compare September 3, 2025 20:54
@BillyONeal BillyONeal added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 3, 2025
Comment thread ports/svt-av1/portfile.cmake
Comment thread ports/svt-av1/vcpkg.json
@sonozaki-noriko sonozaki-noriko force-pushed the svt-av1 branch 2 times, most recently from ca15eaa to 59d3402 Compare September 6, 2025 10:54
@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 8, 2025
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Sep 8, 2025

Marking with vcpkg-team-review to discuss what to do about private headers.

@BillyONeal
Copy link
Copy Markdown
Member

@ras0219-msft points out that the private header in question only contains statics, macros, and 2 extern function declarations meaning our usual ODR concerns are less likely than normal to happen.

Also we all noted that svt-av1 and aom are both "owned" by the same people.

I checked that there are no conflicting generated headers or libs.

@vicroms vicroms merged commit 25d20d6 into microsoft:master Sep 12, 2025
18 checks passed
@sonozaki-noriko sonozaki-noriko deleted the svt-av1 branch September 16, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants