[reactphysics3d] Add new port#47233
Merged
vicroms merged 7 commits intomicrosoft:masterfrom Sep 12, 2025
Merged
Conversation
89139a5 to
b8ea44c
Compare
b8ea44c to
5ecc1ae
Compare
Contributor
Author
|
@microsoft-github-policy-service agree |
dg0yt
reviewed
Sep 9, 2025
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| WINDOWS_USE_MSBUILD |
Contributor
There was a problem hiding this comment.
AFAICS the windows problems are from absence of dll exports and not solved by msbuild.
Suggested change
| WINDOWS_USE_MSBUILD |
Insert at the top:
if(VCPKG_TARGET_IS_WINDOWS)
vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
endif
Contributor
Author
There was a problem hiding this comment.
Yea that's what I've been seeing online but wanted to try with msbuild, I will disable dll for windows then, thanks !
Co-authored-by: Kai Pastor <[email protected]>
Co-authored-by: Kai Pastor <[email protected]>
This reverts commit 55c4481.
vicroms
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19309
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.