Skip to content

[reactphysics3d] Add new port#47233

Merged
vicroms merged 7 commits intomicrosoft:masterfrom
robinwils:reactphysics3d
Sep 12, 2025
Merged

[reactphysics3d] Add new port#47233
vicroms merged 7 commits intomicrosoft:masterfrom
robinwils:reactphysics3d

Conversation

@robinwils
Copy link
Copy Markdown
Contributor

@robinwils robinwils commented Sep 6, 2025

Fixes #19309

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@robinwils
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Comment thread ports/reactphysics3d/portfile.cmake Outdated

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
WINDOWS_USE_MSBUILD
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS the windows problems are from absence of dll exports and not solved by msbuild.

Suggested change
WINDOWS_USE_MSBUILD

Insert at the top:

if(VCPKG_TARGET_IS_WINDOWS)
    vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
endif

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea that's what I've been seeing online but wanted to try with msbuild, I will disable dll for windows then, thanks !

Comment thread ports/reactphysics3d/portfile.cmake Outdated
Comment thread ports/reactphysics3d/usage Outdated
@robinwils robinwils marked this pull request as ready for review September 11, 2025 12:34
@vicroms vicroms merged commit d9edade into microsoft:master Sep 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Port Request] reactphysics3d

3 participants