Preserve permissions using upkg#1625
Conversation
|
What happens if someone had already set up universal packages? Does this change invalidate all their caches or fall over if it sees an 'old world order' upkg? |
To clarify: This is x- and new-ish so I think it's OK if we break existing users, I just think we need to understand what to tell them |
This will invalidate caches. Nothing should "fall over", it should just trigger a new upload / download. |
|
Also can you describe how you tested this? |
Its in the description #1625 (comment) |
That's a screenshot showing it working, I mean, "before signing off on this I want to try it myself, how can I do that?" |
I created an overlay port that installs an executable. I set up an asset cache, logged in, installed the overlay port. Then reinstalled it from the cache and inspected the permissions on the executable. |
|
Closing and reopening to force re-merge with #1648 |
BillyONeal
left a comment
There was a problem hiding this comment.
This approval is contingent on an attestation that you tried the procedure mentioned in the PR description with the current code. (I normally wouldn't mention this but after the 1 revision which deleted the downloaded zip before extracting it coupled with our absolute inability to regression test this makes me paranoid)
Initial install:

After cache download:

Permissions not preserved!
Changing to zip contents…
Original Install:

Observe the write permissions.
Installing from binary cache:

Permissions preserved!