BuildLogsRecorder: Only copy new log files#1657
Merged
BillyONeal merged 2 commits intomicrosoft:mainfrom Apr 25, 2025
Merged
Conversation
BillyONeal
reviewed
Apr 22, 2025
| #else // ^^^ _WIN32 // !_WIN32 vvv | ||
| struct timespec ts; | ||
| clock_gettime(CLOCK_REALTIME, &ts); | ||
| return ts.tv_sec * 1'000'000'000 + ts.tv_nsec; |
Member
There was a problem hiding this comment.
Suggested change
| return ts.tv_sec * 1'000'000'000 + ts.tv_nsec; | |
| return int64_t{ts.tv_sec} * 1'000'000'000 + ts.tv_nsec; |
Otherwise it's not necessarily safe to do that
BillyONeal
reviewed
Apr 22, 2025
| struct CiBuildLogsRecorder final : IBuildLogsRecorder | ||
| { | ||
| explicit CiBuildLogsRecorder(const Path& base_path_); | ||
| explicit CiBuildLogsRecorder(const Path& base_path_, int64_t minimum_last_write_time = 0); |
Member
There was a problem hiding this comment.
Does this need the = 0? It seems like all callers should be required to pass it.
BillyONeal
reviewed
Apr 24, 2025
| #endif // ^^^ !_WIN32 | ||
| } | ||
|
|
||
| int64_t file_time_now() const override |
Member
There was a problem hiding this comment.
Hmmm this doesn't seem to actually touch the filesystem and thus it could just be a nonmember?
Contributor
Author
There was a problem hiding this comment.
Could be. But if you want to implement a fake filesystem you maybe want to change its implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vcpkg#45070 (comment) where logs from a previous run were copied into the logs folder