Skip to content

Merge cascaded failure feature dependencies together.#1665

Merged
BillyONeal merged 2 commits intomicrosoft:mainfrom
BillyONeal:merge-cascade-failures
May 1, 2025
Merged

Merge cascaded failure feature dependencies together.#1665
BillyONeal merged 2 commits intomicrosoft:mainfrom
BillyONeal:merge-cascade-failures

Conversation

@BillyONeal
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal commented Apr 30, 2025 •
edited
Loading

Before:

.\vcpkg.exe install vcpkg-depends-on-fail[x] --overlay-ports C:\Dev\vcpkg-tool\azure-pipelines\e2e-ports --keep-going --binarysource clear
[...]
error: building vcpkg-depends-on-fail:x64-windows failed with: CASCADED_DUE_TO_MISSING_DEPENDENCIES
  due to the following missing dependencies:
    vcpkg-fail-if-depended-upon[a]:x64-windows
    vcpkg-fail-if-depended-upon[core]:x64-windows
    vcpkg-fail-if-depended-upon[b]:x64-windows
    vcpkg-fail-if-depended-upon[core]:x64-windows

After:

.\vcpkg.exe install vcpkg-depends-on-fail[x] --overlay-ports C:\Dev\vcpkg-tool\azure-pipelines\e2e-ports --keep-going --binarysource clear
[...]
error: building vcpkg-depends-on-fail:x64-windows failed with: CASCADED_DUE_TO_MISSING_DEPENDENCIES
  due to the following missing dependencies:
    vcpkg-fail-if-depended-upon[a,b,core]:x64-windows

I discovered this upon seeing that there is a duplicate implementation here I'm removing:

vcpkg-tool/src/vcpkg/commands.test-features.cpp

Line 496 in d3138cb

std::string failed_dependencies;

BillyONeal
BillyONeal commented Apr 30, 2025
View reviewed changes
Comment thread src/vcpkg/commands.build.cpp Outdated
Comment thread azure-pipelines/end-to-end-tests-dir/build-test-ports.ps1
Building vcpkg-depends-on-fail[core,x]:$($Triplet)@0...
error: building vcpkg-depends-on-fail:$($Triplet) failed with: CASCADED_DUE_TO_MISSING_DEPENDENCIES
due to the following missing dependencies:
vcpkg-fail-if-depended-upon[a,b,core]:$($Triplet)
Copy link
Copy Markdown
Member Author

@BillyONeal BillyONeal Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this does not list is-a-default-feature even though we tried to install it here because that isn't actually a dependency of vcpkg-depends-on-fail

@BillyONeal BillyONeal requested a review from JavierMatosD May 1, 2025 19:18
@BillyONeal BillyONeal enabled auto-merge (squash) May 1, 2025 19:54
@BillyONeal BillyONeal merged commit d0e1cbb into microsoft:main May 1, 2025
7 checks passed
@BillyONeal BillyONeal deleted the merge-cascade-failures branch May 1, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JavierMatosD JavierMatosD JavierMatosD approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BillyONeal @JavierMatosD