Improve x-test-features diagnostics.#1676
Merged
BillyONeal merged 19 commits intomicrosoft:mainfrom May 14, 2025
Merged
Conversation
Looking to all calls of handle_feature_test_result: 429: cascade_reason is a join of install_plan.unsupported_features, and the if is guarded by that not being empty on 413. 447: cascade_reason is set to the install action display name 461: Actual isn't cascade. 477: Actual isn't cascade. 549: Actual isn't cascade. 557: It's not entirely clear to prove that failed_dependencies will be nonempty here. However, failed_dependencies is recalculating something already present in ExtendedBuildResult, unmet_dependencies, which is already closely associated with CascadedDueToMissingDependencies Before: test[core]:x64-windows resulted in the unexpected state cascade because the following dependencies did not build: vcpkg-fail-if-depended-upon:x64-windows After: test[core]:x64-windows was unexpectedly a cascading failure because the following dependencies are unavailable: vcpkg-fail-if-depended-upon[a]:x64-windows, vcpkg-fail-if-depended-upon[core]:x64-windows
…o avoid needing to name cascade_reason for non-cascade cases. # Conflicts: # src/vcpkg/commands.test-features.cpp
…strings as input.
…eparate' feature tests. Ensure that the syntax for combination-fails and feature-fails are correct. Always talk about feature names with the port name for clarity.
…the first option in the combined test.
b82a1c9 to
ed9ae01
Compare
JavierMatosD
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substantially overhauls how diagnostics are reported out of x-test-features:
Other changes:
ExtendedBuildResultrather than attempting to recompute this.std::is_permutationwhen determining whether feature tests are the "same" rather than special casing sort then trying theN^2version.