binarycaching: also don't restore file times on windows#1750
Merged
BillyONeal merged 1 commit intomicrosoft:mainfrom Aug 14, 2025
Merged
Conversation
This fixes microsoft/vcpkg#33714, but for windows. 7zip restores file times by default and there is no way to disable it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes microsoft/vcpkg#33714, but for windows. 7zip restores file times by default and there is no way to disable it.
This currently breaks our build at work. We use grpc and the generated headers has to match with the version of grpc that is currently in use. We use the following target but it is not triggered since the last modification date of the restored grpc tool (ProtocExe) is older than the headers:
After this PR it worked as expected.