Clean up the extension activation code.#10455
Merged
ericsnowcurrently merged 18 commits intomicrosoft:masterfrom Mar 11, 2020
Merged
Clean up the extension activation code.#10455ericsnowcurrently merged 18 commits intomicrosoft:masterfrom
ericsnowcurrently merged 18 commits intomicrosoft:masterfrom
Conversation
karthiknadig
reviewed
Mar 6, 2020
karthiknadig
reviewed
Mar 6, 2020
08516fd to
5b3d57d
Compare
DonJayamanne
reviewed
Mar 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #10455 +/- ##
==========================================
- Coverage 60.86% 60.81% -0.05%
==========================================
Files 579 578 -1
Lines 31290 31276 -14
Branches 4449 4448 -1
==========================================
- Hits 19045 19022 -23
- Misses 11282 11289 +7
- Partials 963 965 +2
Continue to review full report at Codecov.
|
kimadeline
reviewed
Mar 9, 2020
kimadeline
approved these changes
Mar 10, 2020
kimadeline
left a comment
There was a problem hiding this comment.
Looks alright, mostly moving things around :)
Could you rename the extension-* files you created to use the camelCase file naming convention we have in the codebase instead of kebab-case?
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
added a commit
that referenced
this pull request
Mar 13, 2020
* master: Fix flakey file system tests (#10541) Tweaks for gather (#10532) Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517) Add conda support to nightly flake test (#10523) Rename datascience to datascience_modules (#10525) Clean up the extension activation code. (#10455) Allow escape and ctrl+U to clear the interactive window (#10513) Fix builtins so they don't interfere with our execution (#10511) Jupyter autocompletion will only show up on empty lines, (#10420) notify on missing kernel and interpreter with kernel (#10508)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #10454)
This is the basic prep work for making the flow of extension activation more clear.
[ ] Has telemetry for enhancements.[ ] Unit tests & system/integration tests are added/updated.[ ] Test plan is updated as appropriate.[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.