Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
approved these changes
Apr 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #11089 +/- ##
==========================================
- Coverage 61.42% 61.39% -0.03%
==========================================
Files 597 597
Lines 32756 32756
Branches 4631 4631
==========================================
- Hits 20121 20112 -9
- Misses 11619 11626 +7
- Partials 1016 1018 +2
Continue to review full report at Codecov.
|
rchiodo
added a commit
that referenced
this pull request
Apr 11, 2020
* Fix monaco editor scrolling and line height * Add news entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #10952
Problems with scrolling on new line (caused by scroll handler being called before the line was actually there)
Problems with scrolling when typing as opposed to just up/down arrow. (caused by scroll handler not waiting for the text to appear so scrolling to a visible line that gets destroyed)
Also fixed a bug in my style speedup code. Sometimes there are no visible lines. In that case, don't remember the default of 18PX.