Conversation
…e custom editor support
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
approved these changes
Apr 15, 2020
rchiodo
added a commit
that referenced
this pull request
Apr 15, 2020
* Put back ctrl+z and 'z' for undo. Refactor to use one value to compute custom editor support * Add news entry
rchiodo
added a commit
that referenced
this pull request
Apr 15, 2020
* Fix undo in notebooks (#11167) * Put back ctrl+z and 'z' for undo. Refactor to use one value to compute custom editor support * Add news entry * Update change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #11160
UseCustomEditor was set to 'true' in the UI.
Changed the logic to use the actual computation we perform and pass it through settings.
When we actually switch to the custom editor we can just remove this.