Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
IanMatthewHuff
approved these changes
Apr 17, 2020
| private scrollToCurrentPosition(_editor: monacoEditor.editor.IStandaloneCodeEditor) { | ||
| // Unfortunately during functional tests we hack the line count and the like. | ||
| if (isTestExecution()) { | ||
| if (isTestExecution() || !this.props.hasFocus) { |
Member
There was a problem hiding this comment.
I was wondering if anything relied on the previous behavior where you could do this to an out of focus cell. But I'm not seeing anything. So looks good.
Member
There was a problem hiding this comment.
Even if it did, I'm guessing that the current behavior is much worse than whatever we'd be breaking.
DavidKutu
approved these changes
Apr 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #11238
Monaco editor was forcing a scroll to its own lines even when it doesn't have focus.