Make node install version in contributing docs match ci.yml#12528
Merged
joyceerhl merged 2 commits intomicrosoft:masterfrom Jun 24, 2020
joyceerhl:update-docs
Merged
Make node install version in contributing docs match ci.yml#12528joyceerhl merged 2 commits intomicrosoft:masterfrom joyceerhl:update-docs
joyceerhl merged 2 commits intomicrosoft:masterfrom
joyceerhl:update-docs
Conversation
DonJayamanne
approved these changes
Jun 24, 2020
DonJayamanne
approved these changes
Jun 24, 2020
DonJayamanne
left a comment
There was a problem hiding this comment.
Pelase could you update the .nvmrc file as well.
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
approved these changes
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our CONTRIBUTING.md docs say to install node 12.*. However our CI uses 12.15, and in fact the functional tests will not run locally with 12.18 (in my experience) or with 12.16 (as reported by Sergio last month). I'm submitting this PR to update the docs to match ci.yml as I just spent a couple hours tracking down this issue.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).