Allow user to opt into/out of trusted nb exp#12789
Merged
joyceerhl merged 1 commit intomicrosoft:masterfrom Jul 7, 2020
joyceerhl:exp-opt
Merged
Allow user to opt into/out of trusted nb exp#12789joyceerhl merged 1 commit intomicrosoft:masterfrom joyceerhl:exp-opt
joyceerhl merged 1 commit intomicrosoft:masterfrom
joyceerhl:exp-opt
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
IanMatthewHuff
approved these changes
Jul 7, 2020
rchiodo
approved these changes
Jul 7, 2020
DavidKutu
approved these changes
Jul 7, 2020
DonJayamanne
approved these changes
Jul 7, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't realize that this works for the new IExperimentService too, provided the enum is added to src/client/common/experiments/groups.ts first.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).