Skip to content

Make trusted message visible on dark backgrounds #12888

Merged
joyceerhl merged 2 commits intomicrosoft:masterfrom
joyceerhl:more-fixes
Jul 10, 2020
Merged

Make trusted message visible on dark backgrounds #12888
joyceerhl merged 2 commits intomicrosoft:masterfrom
joyceerhl:more-fixes

Conversation

@joyceerhl
Copy link
Copy Markdown

@joyceerhl joyceerhl commented Jul 10, 2020

For #12866

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Jul 10, 2020
@joyceerhl joyceerhl changed the title Make trust message visible Make trusted message visible on dark backgrounds Jul 10, 2020
@joyceerhl joyceerhl marked this pull request as ready for review July 10, 2020 20:56
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joyceerhl joyceerhl merged commit a7b70f6 into microsoft:master Jul 10, 2020
DonJayamanne pushed a commit that referenced this pull request Jul 13, 2020
@joyceerhl @DonJayamanne
Make trusted message visible on dark backgrounds (#12888)
acecad7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

+2 more reviewers

@DavidKutu DavidKutu DavidKutu approved these changes

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyceerhl @IanMatthewHuff @rchiodo @DavidKutu @kimadeline