Don't show trust message for IW#13414
Merged
joyceerhl merged 2 commits intomicrosoft:masterfrom Aug 13, 2020
joyceerhl:bugfix
Merged
Don't show trust message for IW#13414joyceerhl merged 2 commits intomicrosoft:masterfrom joyceerhl:bugfix
joyceerhl merged 2 commits intomicrosoft:masterfrom
joyceerhl:bugfix
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13414 +/- ##
==========================================
- Coverage 59.92% 59.90% -0.03%
==========================================
Files 670 670
Lines 37208 37207 -1
Branches 5312 5311 -1
==========================================
- Hits 22297 22287 -10
- Misses 13774 13780 +6
- Partials 1137 1140 +3
Continue to review full report at Codecov.
|
joyceerhl
commented
Aug 13, 2020
| const wrapper = mountComponent('interactive', <InteractivePanel {...props}></InteractivePanel>); | ||
|
|
||
| assert.equal(wrapper.find(TrustMessage).length, 0); | ||
| }); |
Author
There was a problem hiding this comment.
Ran this test locally before and after the fix, and this will fail without the changes made in jupyterInfo.tsx (and it passes now), so it's testing what it claims to.
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
approved these changes
Aug 13, 2020
IanMatthewHuff
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by #13394. Thanks @IanMatthewHuff for catching this!
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).