Skip to content

Revert "Add a locator for executables on $PATH on Windows."#14968

Merged
karthiknadig merged 1 commit intomicrosoft:release-2020.12from
karthiknadig:release-1
Dec 14, 2020
Merged

Revert "Add a locator for executables on $PATH on Windows."#14968
karthiknadig merged 1 commit intomicrosoft:release-2020.12from
karthiknadig:release-1

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

Reverting this only from the release branch. Found this using git bisect:

C:\GIT\s p\vscode-python>git bisect start

C:\GIT\s p\vscode-python>git bisect bad

C:\GIT\s p\vscode-python>git bisect good 0bc0e38c4d1810724464581daf67cfc86df5d2be
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[c8aa0706e7b4d00051317e205fd7694593da3008] Add telemetry when survey prompt is shown (#14940)

C:\GIT\s p\vscode-python>git bisect good
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[df2dff32e9620f37a4c0109cfe59e715287164af] Add a locator for executables on $PATH on Windows. (#14675)

C:\GIT\s p\vscode-python>git bisect bad
Bisecting: 1 revision left to test after this (roughly 1 step)
[bc6c9292473370285600eb605cfdab4055248061] Update main version (#14941)

C:\GIT\s p\vscode-python>git bisect good
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[c836cdafb6d1e8ce87a15fd8de8a1ce37d44f6b6] Do not call resolveEnv in component adapter where it's too expensive. (#14923)

C:\GIT\s p\vscode-python>git bisect good
df2dff32e9620f37a4c0109cfe59e715287164af is the first bad commit
commit df2dff32e9620f37a4c0109cfe59e715287164af
Author: Eric Snow <[email protected]>
Date:   Thu Dec 10 16:55:36 2020 -0700

    Add a locator for executables on $PATH on Windows. (#14675)

 src/client/common/utils/exec.ts                    |  33 ++
 src/client/common/utils/text.ts                    | 135 ++++++
 src/client/pythonEnvironments/base/envsCache.ts    |   3 +-
 .../base/locators/lowLevel/filesLocator.ts         |  44 +-
 .../locators/lowLevel/windowsKnownPathsLocator.ts  |  90 ++++
 .../pythonEnvironments/common/commonUtils.ts       |  24 +-
 .../common/externalDependencies.ts                 |  18 +
 .../locators/services/KnownPathsService.ts         |  17 +-
 src/client/pythonEnvironments/index.ts             |   2 +
 src/test/common/platform/utils.ts                  |   2 +
 src/test/pythonEnvironments/base/common.ts         |  13 +-
 .../windowsKnownPathsLocator.functional.test.ts    | 360 +++++++++++++++
 ...balVirtualEnvironmentLocator.functional.test.ts | 495 +++++++++++++++++++++
 .../globalVirtualEnvironmentLocator.unit.test.ts   | 495 ---------------------
 .../locators/pyenvLocator.functional.test.ts       | 164 +++++++
 .../discovery/locators/pyenvLocator.unit.test.ts   | 158 -------
 src/test/testing/helper.ts                         |  40 --
 src/test/testing/results.ts                        |   3 +-
 src/test/utils/fs.ts                               | 240 ++++++++++
 19 files changed, 1616 insertions(+), 720 deletions(-)
 create mode 100644 src/client/pythonEnvironments/base/locators/lowLevel/windowsKnownPathsLocator.ts
 create mode 100644 src/test/pythonEnvironments/base/locators/lowLevel/windowsKnownPathsLocator.functional.test.ts
 create mode 100644 src/test/pythonEnvironments/discovery/locators/globalVirtualEnvironmentLocator.functional.test.ts
 delete mode 100644 src/test/pythonEnvironments/discovery/locators/globalVirtualEnvironmentLocator.unit.test.ts
 create mode 100644 src/test/pythonEnvironments/discovery/locators/pyenvLocator.functional.test.ts

@karthiknadig karthiknadig merged commit 5f93cd1 into microsoft:release-2020.12 Dec 14, 2020
karrtikr pushed a commit that referenced this pull request Dec 14, 2020
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request Dec 15, 2020
@karthiknadig karthiknadig deleted the release-1 branch January 12, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants