Only force background envs refresh if the component is enabled.#15132
Merged
ericsnowcurrently merged 3 commits intomicrosoft:mainfrom Feb 2, 2021
Merged
Conversation
karthiknadig
approved these changes
Jan 12, 2021
int19h
approved these changes
Jan 12, 2021
karrtikr
reviewed
Jan 12, 2021
| @@ -59,10 +59,12 @@ export function initialize(ext: ExtensionState): PythonEnvironments { | |||
| * Make use of the component (e.g. register with VS Code). | |||
| */ | |||
| export async function activate(api: PythonEnvironments): Promise<ActivationResult> { | |||
There was a problem hiding this comment.
activate() is never called, so I don't think this'll have any effect.
Author
There was a problem hiding this comment.
Yeah, I forgot to fix that. It's fixed now.
181327e to
c45cd3a
Compare
This was referenced Feb 10, 2021
This was referenced Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #14984)
This ensures that the component is not used at all if not in the relevant experiments.
(FYI, this is a branch I had lying around so I figured I'd move it along.)
[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] The wiki is updated with any design decisions/details.