Skip to content

Do not lowercase executable paths returned by Windows path locator#15483

Merged
karrtikr merged 2 commits intomicrosoft:mainfrom
karrtikr:windows
Feb 23, 2021
Merged

Do not lowercase executable paths returned by Windows path locator#15483
karrtikr merged 2 commits intomicrosoft:mainfrom
karrtikr:windows

Conversation

@karrtikr
Copy link
Copy Markdown

@karrtikr karrtikr commented Feb 23, 2021 •
edited
Loading

Closes #15289

@karrtikr karrtikr added no-changelog No news entry required skip tests Updates to tests unnecessary labels Feb 23, 2021
@karrtikr karrtikr removed the skip tests Updates to tests unnecessary label Feb 23, 2021
@karrtikr karrtikr marked this pull request as ready for review February 23, 2021 01:29
ericsnowcurrently
ericsnowcurrently approved these changes Feb 23, 2021
View reviewed changes
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kimadeline
kimadeline approved these changes Feb 23, 2021
View reviewed changes
Copy link
Copy Markdown

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I don't understand why normalizeFilename (called by normalizePath) needs to return a lowercased version of the path instead of using path.normalize directly.

@karrtikr
Copy link
Copy Markdown
Author

karrtikr commented Feb 23, 2021

@kimadeline Yes, it wasn't clear by the name normalizeFilename. normCaseFilename would probably be a better name. @ericsnowcurrently Do you agree? If so, I can take of it in a separate PR.

@karrtikr karrtikr merged commit 66da3ac into microsoft:main Feb 23, 2021
@karrtikr karrtikr deleted the windows branch February 23, 2021 20:39
@ericsnowcurrently
Copy link
Copy Markdown

ericsnowcurrently commented Feb 23, 2021

@kimadeline Yes, it wasn't clear by the name normalizeFilename. normCaseFilename would probably be a better name. @ericsnowcurrently Do you agree? If so, I can take of it in a separate PR.

The responsibility of normalizeFilename() is to provide a consistent, unique representation for a given filename, hence "normalize". Case (for Windows) is only part of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filenames identified by WindowsPathEnvVarLocator have an unexpected format.

3 participants

@karrtikr @ericsnowcurrently @kimadeline