Add support for starting TensorBoard session with a remote log directory via URL#16477
Merged
joyceerhl merged 3 commits intomicrosoft:mainfrom Jul 13, 2021
joyceerhl:dev/joyceerhl/remote-logdir
Merged
Add support for starting TensorBoard session with a remote log directory via URL#16477joyceerhl merged 3 commits intomicrosoft:mainfrom joyceerhl:dev/joyceerhl/remote-logdir
joyceerhl merged 3 commits intomicrosoft:mainfrom
joyceerhl:dev/joyceerhl/remote-logdir
Conversation
rchiodo
reviewed
Jun 14, 2021
| return this.showFilePicker(); | ||
| case enterRemoteUrl: | ||
| return this.applicationShell.showInputBox({ | ||
| prompt: TensorBoard.enterRemoteUrlDetail(), |
There was a problem hiding this comment.
Should there be any validation on the url? I believe we do that for jupyter URIs. Not sure if there's a standard form for tensorboard remote URIs
Author
There was a problem hiding this comment.
I was debating this. This can be any web URL AFAIK. I didn't really want to roll my own validation here. One thought I had was since VS Code has a URI implementation that can parse URLs, we could either hand off the URL to their Uri.parse function and check if the key properties are empty string, or duplicate the regex and logic they use for validation. But it would probably also work to just reuse our existing validation logic.
rchiodo
approved these changes
Jun 14, 2021
IanMatthewHuff
approved these changes
Jun 14, 2021
kimadeline
approved these changes
Jun 14, 2021
paulacamargo25
approved these changes
Jun 15, 2021
Member
|
@joyceerhl can you either merge or close this PR? |
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Jul 14, 2021
…ory via URL (microsoft#16477) * Add support for remote logdirs * Add missing keys * Fix typo
karthiknadig
added a commit
that referenced
this pull request
Jul 16, 2021
* Bump actions/setup-node from 2.1.5 to 2.2.0 (#16592) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for starting TensorBoard session with a remote log directory via URL (#16477) * Add support for remote logdirs * Add missing keys * Fix typo * Bump isort from 5.8.0 to 5.9.2 (#16636) Bumps [isort](https://github.com/pycqa/isort) from 5.8.0 to 5.9.2. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.8.0...5.9.2) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Make getInterpreters() API faster for subsequent calls (#16674) * Change the way auto-selection works (#16644) * New comparison logic * Add experiment group * Register and call it * Add service registry tests * Add interpreter selector unit tests * Add comparison unit tests * Add intepreter selector test * News file * Adjust comments * Reuse getSortName * Add new auto-selection logic * Add tests for getEnvTypeHeuristic * Move persistent store initialization back out * Update tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]>
karthiknadig
added a commit
that referenced
this pull request
Jul 22, 2021
* Fix 'Cannot read property 'resolveEnv' of undefined' error (#16677) * Cherry pick fixes into release (#16686) * Bump actions/setup-node from 2.1.5 to 2.2.0 (#16592) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for starting TensorBoard session with a remote log directory via URL (#16477) * Add support for remote logdirs * Add missing keys * Fix typo * Bump isort from 5.8.0 to 5.9.2 (#16636) Bumps [isort](https://github.com/pycqa/isort) from 5.8.0 to 5.9.2. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.8.0...5.9.2) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Make getInterpreters() API faster for subsequent calls (#16674) * Change the way auto-selection works (#16644) * New comparison logic * Add experiment group * Register and call it * Add service registry tests * Add interpreter selector unit tests * Add comparison unit tests * Add intepreter selector test * News file * Adjust comments * Reuse getSortName * Add new auto-selection logic * Add tests for getEnvTypeHeuristic * Move persistent store initialization back out * Update tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]> * Change version for release (#16722) * Ensure we block on autoselection when no interpreter is explictly set by user (#16723) * Ensure we block on autoselection when no interpreter is explictly set by user * Added tests * News entry * Update change log for release. (#16731) * Fix autoselection when opening a python file directly (#16733) * Fix autoselection when opening a python file directly * Update changelog * Add tests * Ignore cache when querying for interpreters during auto-selection (#16734) * Ignore cache when getting envs for autoselection * Don't call autoSelectInterpreter twice * Update debugger via point release (#16746) * Update version * Update change log * Update wheels to 3.9 (#16745) * Clean up Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]>
karthiknadig
added a commit
that referenced
this pull request
Jul 28, 2021
* Fix 'Cannot read property 'resolveEnv' of undefined' error (#16677) * Cherry pick fixes into release (#16686) * Bump actions/setup-node from 2.1.5 to 2.2.0 (#16592) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for starting TensorBoard session with a remote log directory via URL (#16477) * Add support for remote logdirs * Add missing keys * Fix typo * Bump isort from 5.8.0 to 5.9.2 (#16636) Bumps [isort](https://github.com/pycqa/isort) from 5.8.0 to 5.9.2. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.8.0...5.9.2) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Make getInterpreters() API faster for subsequent calls (#16674) * Change the way auto-selection works (#16644) * New comparison logic * Add experiment group * Register and call it * Add service registry tests * Add interpreter selector unit tests * Add comparison unit tests * Add intepreter selector test * News file * Adjust comments * Reuse getSortName * Add new auto-selection logic * Add tests for getEnvTypeHeuristic * Move persistent store initialization back out * Update tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]> * Change version for release (#16722) * Ensure we block on autoselection when no interpreter is explictly set by user (#16723) * Ensure we block on autoselection when no interpreter is explictly set by user * Added tests * News entry * Update change log for release. (#16731) * Fix autoselection when opening a python file directly (#16733) * Fix autoselection when opening a python file directly * Update changelog * Add tests * Ignore cache when querying for interpreters during auto-selection (#16734) * Ignore cache when getting envs for autoselection * Don't call autoSelectInterpreter twice * Update debugger via point release (#16746) * Update version * Update change log * Update wheels to 3.9 (#16745) * Point release with debugpy fix (#16776) Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #16461
The PyTorch profiler plugin now accepts a remote log directory for profiler logs. This allows our users to leverage that support when creating TensorBoard sessions.