Wait for pylance instead of failing in the browser#17033
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Aug 19, 2021
Merged
Wait for pylance instead of failing in the browser#17033jakebailey merged 1 commit intomicrosoft:mainfrom
jakebailey merged 1 commit intomicrosoft:mainfrom
Conversation
karthiknadig
approved these changes
Aug 19, 2021
jakebailey
added a commit
to jakebailey/vscode-python
that referenced
this pull request
Aug 19, 2021
karthiknadig
pushed a commit
that referenced
this pull request
Aug 19, 2021
karthiknadig
added a commit
that referenced
this pull request
Aug 23, 2021
* Update version and change log. (#16868) * Deprecate inExperiment API in favor of inExperimentSync (#16848) * Deprecate inExperiment API in favour of inExperimentSync * Ensure experiments are activated before they are used * News entry * Fix order of default unittest arguments (#16880) * Fix order of default unittest arguments * Add news entry * Update version and change log * Add webpack build for browser entrypoint (#16912) * Get telemetry client and LS middleware working in the browser (#17010) * Add typings/types to browser tsconfig * Wait for pylance instead of failing in the browser (#17033) (#17036) * Update version number and change log for point release (#17023) * Update versions * Update change log. * Update CHANGELOG date * Update version and change log for point release. (#17074) * Update `vsce` to latest. (#17051) * Update vscode-extension-telemetry to 0.2.9 (#17071) * Update vscode-extension-telemetry to 0.2.9 * Remove todo * Remove other todo * Exact * Update version and change log for point release. Co-authored-by: Jake Bailey <[email protected]> Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Nikolay Kondratyev <[email protected]> Co-authored-by: Jake Bailey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code would just throw, but we can just register a handler that will check to see if Pylance is installed and then start the LS. This makes sideloading to test simpler.