Skip to content

Moved LSP to the latest version that has race fixed#19136

Merged
karthiknadig merged 3 commits intomicrosoft:mainfrom
heejaechang:lspWithRaceFix
May 12, 2022
Merged

Moved LSP to the latest version that has race fixed#19136
karthiknadig merged 3 commits intomicrosoft:mainfrom
heejaechang:lspWithRaceFix

Conversation

@heejaechang
Copy link
Copy Markdown

No description provided.

@heejaechang heejaechang requested a review from kimadeline May 12, 2022 16:46
@heejaechang heejaechang added no-changelog No news entry required skip tests Updates to tests unnecessary labels May 12, 2022
@heejaechang
Copy link
Copy Markdown
Author

@karrtikr @kimadeline I confirmed this fix the race. once this is in, can we release point release?

@kimadeline kimadeline assigned kimadeline and unassigned karrtikr May 12, 2022
Copy link
Copy Markdown

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig can we do another point-release with this fix?

@karthiknadig
Copy link
Copy Markdown
Member

Certainly, can we add a news item to this.

@heejaechang
Copy link
Copy Markdown
Author

@karthiknadig do we have issue number that I can use for news entry?

@karthiknadig
Copy link
Copy Markdown
Member

You can use this #19139

@heejaechang heejaechang removed the no-changelog No news entry required label May 12, 2022
@heejaechang
Copy link
Copy Markdown
Author

@karthiknadig done

@karthiknadig karthiknadig merged commit 84b85cb into microsoft:main May 12, 2022
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request May 12, 2022
* moved lsp to latest version that has race fixed

* updated middleware

* added news entry
karthiknadig added a commit that referenced this pull request May 12, 2022
* Indicate the Python output channel has to be manually filled in the issue template (#19130)

* Moved LSP to the latest version that has race fixed (#19136)

* moved lsp to latest version that has race fixed

* updated middleware

* added news entry

* Fix news entry encoding.

* Update versions and changelog

Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Heejae Chang <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…-python#19136)

* moved lsp to latest version that has race fixed

* updated middleware

* added news entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants