Skip to content

Cherry fixes for point release#19996

Merged
karrtikr merged 3 commits intorelease/2022.16from
kartik/chery
Oct 12, 2022
Merged

Cherry fixes for point release#19996
karrtikr merged 3 commits intorelease/2022.16from
kartik/chery

Conversation

@karrtikr
Copy link
Copy Markdown

No description provided.

Kartik Raj added 2 commits October 12, 2022 17:27
…les (#19986)

Reverts #19819 Closes
#19967

Until we have a better activation story:
#11039, where we
potentially get rid of using `conda activate` commands, use `conda run`
for fetching environment variables even though it's slower.

Created #19987 for
tackling it in the future.

FYI @DonJayamanne
@karrtikr karrtikr requested a review from karthiknadig October 12, 2022 17:30
@karrtikr karrtikr added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels Oct 12, 2022
@karthiknadig
Copy link
Copy Markdown
Member

@karrtikr Can you run npm install?

@karrtikr
Copy link
Copy Markdown
Author

@karthiknadig Sorry, done.

@karrtikr karrtikr removed the skip package*.json package.json and package-lock.json don't both need updating label Oct 12, 2022
@karrtikr karrtikr merged commit 347094f into release/2022.16 Oct 12, 2022
@karrtikr karrtikr deleted the kartik/chery branch October 12, 2022 18:18
@viviansmlie
Copy link
Copy Markdown

where is .vsix?

@karthiknadig
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants