Skip to content

fix len error (#5421)#5422

Merged
IanMatthewHuff merged 1 commit intoreleasefrom
dev/ianhu/releaseFixLenIssue
Apr 23, 2019
Merged

fix len error (#5421)#5422
IanMatthewHuff merged 1 commit intoreleasefrom
dev/ianhu/releaseFixLenIssue

Conversation

@IanMatthewHuff
Copy link
Copy Markdown
Member

@IanMatthewHuff IanMatthewHuff commented Apr 23, 2019

For #5420

Port from master into release

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff requested a review from rchiodo April 23, 2019 00:38
@IanMatthewHuff IanMatthewHuff merged commit 21d28f9 into release Apr 23, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/releaseFixLenIssue branch April 23, 2019 01:06
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo Awaiting requested review from rchiodo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@IanMatthewHuff