Fix experiments hash parsing #6492
Merged
kimadeline merged 3 commits intomicrosoft:releasefrom Jul 8, 2019
Merged
Conversation
added 2 commits
July 8, 2019 11:44
* Fix broken python tests in news * Revert changes
karrtikr
suggested changes
Jul 8, 2019
| const hash = crypto.createHash('blabla', 'string'); | ||
| assert.typeOf(hash, 'string', 'Type should be a string'); | ||
| }); | ||
| test('If hashFormat equals `number`, the hash should not be NaN', async () => { |
There was a problem hiding this comment.
We should have a test where parseInt(hash, undefined) fails and parseInt(hash, 16) does not. Right now, if I reverted the change in crypto.ts, the tests will still pass.
karrtikr
approved these changes
Jul 8, 2019
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for covering these possibilities!
kimadeline
added a commit
to kimadeline/vscode-python
that referenced
this pull request
Jul 9, 2019
* Simplify & fix crypto.createHash * Add tests * Fix python test in news folder (microsoft#6398) * Fix broken python tests in news * Revert changes
kimadeline
added a commit
to kimadeline/vscode-python
that referenced
this pull request
Jul 9, 2019
* Simplify & fix crypto.createHash * Add tests * Fix python test in news folder (microsoft#6398) * Fix broken python tests in news * Revert changes
kimadeline
added a commit
that referenced
this pull request
Jul 10, 2019
* Fix experiments hash parsing (#6492) * Simplify & fix crypto.createHash * Add tests * Fix python test in news folder (#6398) * Fix broken python tests in news * Revert changes * Release cherry pick (#6515) * Enable experiment for always displaying the test explorer (#6330) * Add logging * Point release - Updated package.json and CHANGELOG (#6516)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6400
createHash(we don't expose theencodingparameter anymore)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)