Skip to content

Ids of new cells must be provided to actions#9833

Merged
DonJayamanne merged 3 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne:passCellIdInCreation
Jan 30, 2020
Merged

Ids of new cells must be provided to actions#9833
DonJayamanne merged 3 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne:passCellIdInCreation

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Jan 30, 2020 •
edited
Loading

For #9340 (more PRs to come, this PR focuses on some minor refactoring).

  • When adding a new cell, the ids must be provided to the redux store actions, instead of the actions generating their own ids.
  • Any operation that results in creation of a cell will ensure a id for the cell is provided
  • DeleteAllCells is an operation that has a side effect of creating a new cell, hence this must provide the id of the new cell that will be created.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 30, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 30, 2020 •
edited
Loading

Codecov Report

Merging #9833 into ds/custom_editor will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           ds/custom_editor    #9833      +/-   ##
====================================================
- Coverage             60.64%   60.64%   -0.01%     
====================================================
  Files                   555      555              
  Lines                 29726    29726              
  Branches               4479     4479              
====================================================
- Hits                  18028    18027       -1     
- Misses                10697    10699       +2     
+ Partials               1001     1000       -1
Impacted Files Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts 100% <ø> (ø) ⬆️
src/client/common/utils/platform.ts 70.58% <0%> (-5.89%) ⬇️
src/client/constants.ts 80% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ec45f...ab3a09c. Read the comment docs.

IanMatthewHuff
IanMatthewHuff reviewed Jan 30, 2020
View reviewed changes
rchiodo
rchiodo approved these changes Jan 30, 2020
View reviewed changes
Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

IanMatthewHuff
IanMatthewHuff approved these changes Jan 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne DonJayamanne merged commit 35d6f66 into microsoft:ds/custom_editor Jan 30, 2020
@DonJayamanne DonJayamanne deleted the passCellIdInCreation branch February 5, 2020 17:47
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

+1 more reviewer

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo @DavidKutu