fix kernel and server labels when not connected#9965
fix kernel and server labels when not connected#9965IanMatthewHuff merged 1 commit intomicrosoft:masterfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| ); | ||
| } else { | ||
| return ( | ||
| <div className="kernel-status-section kernel-status-status" style={displayNameTextWidth}> |
There was a problem hiding this comment.
Q: Why not show nothing here like we discussed?
A: There is way more funk here with the CSS than I expected. All the flexbox work for making the kernel / server selection shrink correctly kinda assumes that there is something here. Just having "No Kernel" here makes the layout look fine without having to monkey with the CSS flexboxes just before release.
Codecov Report
@@ Coverage Diff @@
## master #9965 +/- ##
=========================================
+ Coverage 61.18% 61.2% +0.01%
=========================================
Files 564 564
Lines 30077 30079 +2
Branches 4550 4550
=========================================
+ Hits 18404 18409 +5
+ Misses 10642 10640 -2
+ Partials 1031 1030 -1
Continue to review full report at Codecov.
|
For #9933
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).