CachedClient: Send If-None-Match even with Last-Modified#24
Merged
milo merged 1 commit intomilo:masterfrom Dec 11, 2018
Merged
Conversation
Owner
|
Thank you! |
Owner
|
Released version 1.4.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some requests, GitHub may reply with a "304 Not Modified" even when some parts of the request have changed since the date in the "If-Modified-Since" header. The observed instance of this scenario was for adding assets to a release.
GitHub support admits that this behavior is unexpected, but suggests to use If-None-Match in such cases.
There is no apparent downside to sending both
If-Modified-SinceandIf-None-Matchheaders, so do so.