Avoid sending network Ids if not specified#1
Conversation
|
Hi! Could you just fix the spelling mistakes in the commit message? :) From a quick glance: s@networki@network@g and s@trigerring@triggering@g |
Specifying network Ids in Basic zone is not allowed. Passing an empty array of network Ids is not enough as the empty parameter will still be sent triggering an error. We have to completely avoid sending the parameter in case the network Ids array is empty.
|
Done, sorry about that. |
…pecified Avoid sending network Ids if not specified
|
thanks for your contribution @petrhosek ! I should really clean this library up wrt to tests and documentation. Makes me feel a bit bad when I think about the current state :) Also there is another library which also implements cloudstack support in golang. Perhaps it's time to merge the projects. |
|
I've started testing your CloudStack Packer builder against our local CloudStack deployment and hit various issues, this being one of them. I've already managed to resolve most of the issues and I'll have more pull requests coming to both projects in the following days as I clean up the code a little. |
|
👍 |
Specifying network Ids in Basic zone is not allowed. Passing
an empty array of network Ids is not enough as the empty parameter
will still be sent triggering an error. We have to completely avoid
sending the parameter in case the network Ids array is empty.