Return descriptive and comparable errors#6
Return descriptive and comparable errors#6mitchellh merged 3 commits intomitchellh:masterfrom jghiloni:master
Conversation
|
It's the same except now you need Go 1.13+ to test 😬 |
|
do we need to test as far back as 1.7? Edit: i think i have a fix in mind, I'll add it |
The code has been refactored that pre-go1.13, the behavior is identical to the way it was before. Tested on go1.15, 1.12 (reverted the updated go.mod to its original state), and 1.7.6
mitchellh
left a comment
There was a problem hiding this comment.
This looks good! I don't think we need to support before Go 1.13 so if you want to revert that commit I'd be fine bumping the requirements up.
|
Well I've got everything working now way far back to 1.7, so happy to leave it as is for any legacy users |
|
will leave that choice up to you, happy to revert if you'd rather that for code cleanliness |
|
@mitchellh I will revert that commit and bump your travis.yml so it's only testing 1.13 and tip |
This reverts commit 1f54a4f.
|
Hi @mitchellh! Has there been any movement on this? Thanks! |
|
Hi folks! This sure would be nice to have, any chance we could get it merged in? |
|
Sorry I dropped this! Merging. |
|
thanks! 🙏 |
There are situations in my use case where I need to be able to tell if
Getis erroring because it can't find the key (a case I want to ignore) or for some other reason (that I do not want to ignore).I've developed this in such a way that no error messages have changed and all existing tests pass. This should introduce no changes to how folks are using it now if they don't want to change.