I added code in the assignment_1.ipynb as per the assignment instructions#1
Open
I added code in the assignment_1.ipynb as per the assignment instructions#1
Conversation
juliagallucci
approved these changes
Feb 17, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good. One note for conciseness: sorted_word_a == sorted_word_b already evaluates to True or False, so the print statement is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added the code for the assignment 1.
What did you learn from the changes you have made?
I created two functions that check if two words are anagrams of each other, as well as checks for case sensitivity/insensitivity.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I was pretty set on the sorted() function from the get go.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Initially I had trouble understanding the second part of the assignment, because I first thought the is_case_sensitive value (True, False) was for us to say if the two words had all uppercase/lowecase the same or not. Thus, if is_case_sensitive == True and the uppercase/lowercase were indeed all the same, then the result would be True. But if the uppercase/lowercase were not the same and we passed True for is_case_sensitive, then the result would be False etc.
I changed the code once I understood the proper requirements.
How were these changes tested?
I added some more lines to test my code with different words and conditions.
A reference to a related issue in your repository (if applicable)
Checklist