Skip to content

I added code in the assignment_1.ipynb as per the assignment instructions#1

Open
miyohtnk wants to merge 2 commits intomainfrom
assignment-one
Open

I added code in the assignment_1.ipynb as per the assignment instructions#1
miyohtnk wants to merge 2 commits intomainfrom
assignment-one

Conversation

@miyohtnk
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I added the code for the assignment 1.

What did you learn from the changes you have made?

I created two functions that check if two words are anagrams of each other, as well as checks for case sensitivity/insensitivity.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I was pretty set on the sorted() function from the get go.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Initially I had trouble understanding the second part of the assignment, because I first thought the is_case_sensitive value (True, False) was for us to say if the two words had all uppercase/lowecase the same or not. Thus, if is_case_sensitive == True and the uppercase/lowercase were indeed all the same, then the result would be True. But if the uppercase/lowercase were not the same and we passed True for is_case_sensitive, then the result would be False etc.
I changed the code once I understood the proper requirements.

How were these changes tested?

I added some more lines to test my code with different words and conditions.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. One note for conciseness: sorted_word_a == sorted_word_b already evaluates to True or False, so the print statement is unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants