I completed assignment 2 based on the requirements#2
Open
Conversation
kelichiu
approved these changes
Mar 1, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Pass
Code Execution
All code cells execute without errors (other than the additional intended ones).
Code Quality
Code is well-organized, concise, and includes necessary comments for clarity.
Data Handling
Data files are correctly handled and processed.
Adherence to Instructions
Follows all instructions and requirements as per the assignment.
Specific Criteria
- Reading in our files
Correctly prints out information from the first file. - Summarizing our data
Correctly defines patient_summary() function. Function processes data as per operation and outputs correctly shaped data (60 entries). - Checking for Errors
Correctly defines detect_problems() function. Function uses patient_summary() and check_zeros() to identify mean inflammation of 0 accurately.
Overall Assessment
Meets all the general and specific criteria, indicating a strong understanding of the assignment objectives.
kelichiu
reviewed
Mar 1, 2025
| " # YOUR CODE HERE: Iterate through the variable using a for loop and print each row for inspection" | ||
| " variable_inflammation= f.readlines()\n", | ||
| " # YOUR CODE HERE: Iterate through the variable using a for loop and print each row for inspection\n", | ||
| " for i in range(len(variable_inflammation)): #len() is the number of items, and in the case of inflammation_01.csv, there are 60 items- this way we don't have to know what is the exact range\n", |
There was a problem hiding this comment.
Great use of len(). We could also just do:
for i in variable_inflammation:
print(i)
This will make the code cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added code as per the assignment 2 requirements.
What did you learn from the changes you have made?
I learned how to make more efficient functions and to use functions within functions.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Not applicable.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I was not sure how I would make sure that the functions were correct, so I ended up breaking it down into its components and running each line to see what it would do. I did this on a separate file, where I had access to the inflammation_n.csv files. Once I was able to make it work, I transferred it to the original assignment 2 file.
How were these changes tested?
In #3, I tried out a number of combinations to see when I would get a False or True result. In #2, I tried all three summary statistics to make sure that they worked.
A reference to a related issue in your repository (if applicable)
Not applicable.
Checklist