Start experiment ID with 0 if no experiments exist#641
Merged
tomasatdatabricks merged 1 commit intomlflow:masterfrom Oct 19, 2018
pipedrive:hotfix/create-experiment
Merged
Start experiment ID with 0 if no experiments exist#641tomasatdatabricks merged 1 commit intomlflow:masterfrom pipedrive:hotfix/create-experiment
tomasatdatabricks merged 1 commit intomlflow:masterfrom
pipedrive:hotfix/create-experiment
Conversation
tomasatdatabricks
suggested changes
Oct 18, 2018
Contributor
tomasatdatabricks
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Can you please add a test as well?
Contributor
Author
|
@tomasatdatabricks could you please glance to travis report. Looks, like failed tests are not related with this patch. |
Contributor
|
Yes, it's a conda issue. I am looking into it. |
Contributor
Author
|
@tomasatdatabricks as I see, conda issue is fixed. Pls review again |
tomasatdatabricks
approved these changes
Oct 19, 2018
Contributor
tomasatdatabricks
left a comment
There was a problem hiding this comment.
LGTM, thanks @schipiga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual for case, when custom folder is used for tracking, and no experiments were created there before.