Skip to content

Assignment two#2

Open
mlopezza wants to merge 4 commits intomainfrom
Assignment-two
Open

Assignment two#2
mlopezza wants to merge 4 commits intomainfrom
Assignment-two

Conversation

@mlopezza
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@DwardEE DwardEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and work on the diagrams!

This is a very solid submission. The biggest recurring issue is adding unnecessary GROUP BY clauses (ROW_NUMBER query, last SELECT in temp tables), which could drop rows unintentionally. The COUNT() problem also doesn’t fully follow the “windw function” requirement. But your intent is clear, and almost all queries return correct results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants