Add-locale-aware-guild-and-arena-team-names-for-random-bots-V2#2088
Open
Wishmaster117 wants to merge 23 commits intomod-playerbots:test-stagingfrom
Open
Conversation
…arena-team-names-for-random-bots-V2
…s-for-random-bots-V2
…6_02_03_03_playerbots_translated_french_guilds_name.sql
|
Celandriel
reviewed
Feb 11, 2026
Master update from Test-staging: Fix ObjectAccessor retrieval, optimize EquipActions, and implement RaidBossHelpers
…m-names-for-random-bots-V2
…arena-team-names-for-random-bots-V2
This reverts commit c86032f.
Contributor
Author
|
Converted to draft till guild and arena bug solved |
Master update from Test staging
Update master from Test staging and Core Update
Test staging to master
Test staging to master
…m-names-for-random-bots-V2
…arena-team-names-for-random-bots-V2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request
This PR introduces a multi‑language system for random bot guild names and arena team names in mod‑playerbots, allowing each server to generate names matching its configured locale.
It is needed because previously all random guild/arena names were locked to enUS, forcing non‑English servers to manually edit or fork the module.
This change keeps the system lightweight, database‑driven, and fully backward‑compatible thanks to automatic fallback to enUS.
Design Philosophy
This change aligns with the project’s principles:
Feature Evaluation
Minimum logic required
Select the correct localized column based on the configured locale, and fall back to enUS if empty.
Cheapest acceptable implementation
Add locale‑specific columns to the two existing tables and adjust the factory to pick the right one. No core changes, no extra processing.
Runtime cost across many bots
Negligible. Name generation already queries the DB; selecting one additional column has no measurable impact.
How to Test the Changes
DBC.Localeinworldserver.conf(e.g.DBC.Locale = 2for frFR).playerbots_guild_namesplayerbots_arena_team_namesRestart, then set both back to 0.
Complexity & Impact
Does this change add new decision branches?
Does this change increase per-bot or per-tick processing?
Could this logic scale poorly under load?
Defaults & Configuration
If this introduces more advanced or AI-heavy logic:
AI Assistance
If yes, please specify:
Final Checklist
Notes for Reviewers
This PR does not increase behavioral realism or bot intelligence.
It simply adds a lightweight, database‑driven localization layer for random guild and arena team names, with zero impact on performance or decision‑making logic.