Added 'instance unbind' command to bots#2146
Draft
trolloks wants to merge 3 commits intomod-playerbots:test-stagingfrom
Draft
Added 'instance unbind' command to bots#2146trolloks wants to merge 3 commits intomod-playerbots:test-stagingfrom
trolloks wants to merge 3 commits intomod-playerbots:test-stagingfrom
Conversation
Contributor
|
Hi, thanks for the PR, if merged please add MultiBot Need Update tag |
Collaborator
|
Very nice and convenient |
kadeshar
reviewed
Feb 17, 2026
| public: | ||
| InstanceUnbindAction(PlayerbotAI* botAI) : Action(botAI, "instance unbind") {} | ||
| bool Execute(Event event) override; | ||
| }; |
Collaborator
There was a problem hiding this comment.
I think such commands should be executable only by GM
Contributor
Author
|
NOTE: Hold off on this PR until securiy level change is merged |
kadeshar
reviewed
Mar 12, 2026
| INSERT INTO `ai_playerbot_texts` | ||
| (`name`, `text`, `say_type`, `reply_type`, | ||
| `text_loc1`, `text_loc2`, `text_loc3`, `text_loc4`, | ||
| `text_loc5`, `text_loc6`, `text_loc7`, `text_loc8`) |
Collaborator
There was a problem hiding this comment.
Check file 2026_01_31_00_ai_playerbot_multi_pvp_text_variables.sql
Script require DELETE + INSERT should have id
Also missing INSERT to ai_playerbot_texts_chance
Comment on lines
+270
to
+279
| Player* master = GetMaster(); | ||
| if (!master || master->GetSession()->GetSecurity() < SEC_GAMEMASTER) | ||
| { | ||
| std::string error = PlayerbotTextMgr::instance().GetBotTextOrDefault( | ||
| "instance_unbind_gm_error", "You must be a GM to use instance unbind", {}); | ||
| botAI->TellError(error); | ||
| return false; | ||
| } | ||
| std::string text = PlayerbotTextMgr::instance().GetBotTextOrDefault( | ||
| "instance_unbind_response", "I'm unbinding instances", {}); |
Collaborator
There was a problem hiding this comment.
Im not sure about that. Such checks should be in isPossible or isUseful not in Execute
Celandriel
reviewed
Mar 19, 2026
| return true; | ||
| } | ||
|
|
||
| bool InstanceUnbindAction::Execute(Event event) |
Collaborator
There was a problem hiding this comment.
mark unused event parameter with /event/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
While testing raid strategies i found it cumbersome to keep manually clearing instance locks for every one of my altbots.
I checked the codebase and found two things:
I added a command that just directly calls UnbindInstance via a whisper or party/raid chat to streamline this requirement.
Design Philosophy
We prioritize stability, performance, and predictability over behavioral realism.
Complex player-mimicking logic is intentionally limited due to its negative impact on scalability, maintainability, and
long-term robustness.
Excessive processing overhead can lead to server hiccups, increased CPU usage, and degraded performance for all
participants. Because every action and
decision tree is executed per bot and per trigger, even small increases in logic complexity can scale poorly and
negatively affect both players and
world (random) bots. Bots are not expected to behave perfectly, and perfect simulation of human decision-making is not a
project goal. Increased behavioral
realism often introduces disproportionate cost, reduced predictability, and significantly higher maintenance overhead.
Every additional branch of logic increases long-term responsibility. All decision paths must be tested, validated, and
maintained continuously as the system evolves.
If advanced or AI-intensive behavior is introduced, the default configuration must remain the lightweight decision
model. More complex behavior should only be
available as an explicit opt-in option, clearly documented as having a measurable performance cost.
Principles:
Stability before intelligence
A stable system is always preferred over a smarter one.
Performance is a shared resource
Any increase in bot cost affects all players and all bots.
Simple logic scales better than smart logic
Predictable behavior under load is more valuable than perfect decisions.
Complexity must justify itself
If a feature cannot clearly explain its cost, it should not exist.
Defaults must be cheap
Expensive behavior must always be optional and clearly communicated.
Bots should look reasonable, not perfect
The goal is believable behavior, not human simulation.
Before submitting, confirm that this change aligns with those principles.
Feature Evaluation
Please answer the following:
How to Test the Changes
Complexity & Impact
Does this change add new decision branches?
Does this change increase per-bot or per-tick processing?
Could this logic scale poorly under load?
Defaults & Configuration
Does this change modify default bot behavior?
Bots respond to 'instance unbind' command
If this introduces more advanced or AI-heavy logic:
AI Assistance
Was AI assistance (e.g. ChatGPT or similar tools) used while working on this change?
If yes, please specify:
AI tool or model used (e.g. ChatGPT, GPT-4, Claude, etc.)
Copilot
Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation)
Translation
Which parts of the change were influenced or generated
The translations for bot messages added to the db script
Whether the result was manually reviewed and adapted
Unable to review, since i don't speak those languages
AI assistance is allowed, but all submitted code must be fully understood, reviewed, and owned by the contributor.
Any AI-influenced changes must be verified against existing CORE and PB logic. We expect contributors to be honest
about what they do and do not understand.
Final Checklist
Notes for Reviewers
Anything that significantly improves realism at the cost of stability or performance should be carefully discussed
before merging.